Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy mode #716

Closed
wants to merge 4 commits into from
Closed

Conversation

karpetrosyan
Copy link
Member

Refs: #714

@tomchristie
Copy link
Member

I'd suggest that we don't consider this until we've got #714 resolved, and pushed all the way through to support in HTTPX.

Seem reasonable?

@karpetrosyan
Copy link
Member Author

It's up to you, but I'd suggest adding this feature now to support HTTPS forwarding, as most proxy servers do.

#714 appears to be a lot of work; is it worthwhile to wait for it?

@tomchristie
Copy link
Member

My reservations here...

I'm trying to push towards us starting changes off as design discussions first, rather than code-changes first. We don't yet have the different proxy modes well-documented in the way that the urllib3 project has, and we haven't had any user requests for this functionality that I know of?

Perhaps you could open a discussion with the example you've given here so we can work through that first from a motivation POV rather than jumping straight into the code changes?

@karpetrosyan
Copy link
Member Author

karpetrosyan commented Jun 13, 2023

I started a discussion here, but after not receiving any responses for a while, I decided it would be better to demonstrate it in a PR.

@T-256 T-256 mentioned this pull request Jun 17, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants