adjust GitHub actions to test Django versions #7910
Conversation
878cf60 to
8b3b0ce
Compare
8b3b0ce to
267b97d
Compare
|
It looks like the |
267b97d to
e27b29f
Compare
| python setup.py bdist_wheel | ||
| rm -r djangorestframework.egg-info # see #6139 | ||
| tox -e base,dist,docs | ||
| tox -e dist --installpkg ./dist/djangorestframework-*.whl |
There was a problem hiding this comment.
This appears to be no longer needed
| ENV_PREFIX=$(tr -C -d "0-9" <<< "${{ matrix.python-version }}") | ||
| TOXENV=$(tox --listenvs | grep "^py$ENV_PREFIX" | tr '\n' ',') tox |
There was a problem hiding this comment.
This will be filled in by tox-gh-actions and with ymyzk/tox-gh-actions#60 it could specify everything.
e27b29f to
e70175b
Compare
e70175b to
475bfc4
Compare
| TOX_EXIT=0 | ||
| tox || TOX_EXIT=$? | ||
|
|
||
| if [[ $DJANGO == '3.2' && ${{ matrix.python-version }} == '3.9' ]]; then |
There was a problem hiding this comment.
This could be done as before, but I believe it would not be run if the first fails. This should allow both to run and report an error if either fails.
|
I purposefully dropped this in #7903, it was not an accident. The tests run in decent time just splitting by Python version. Splitting by Django version uses a lot more compute power for not much gain. It also requires a lot more config, as you have here, which often ends up bitrotting or getting the grid wrong. |
|
Ok, it wasn't obvious that was the case since there's no comment in the PR that it was intentional. Isn't the gain that different versions of Django are tested for compatibility though? Not sure if you're arguing it's stable enough or that people make a point to stay up to date with Django. |
Description
This PR adds testing different Django versions which looks like it was dropped in #7903