Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed runTechAndGetContent method: use utf-8 #2

Merged
merged 1 commit into from
Jun 24, 2015
Merged

Fixed runTechAndGetContent method: use utf-8 #2

merged 1 commit into from
Jun 24, 2015

Conversation

blond
Copy link
Member

@blond blond commented Jun 23, 2015

No description provided.

@blond blond added the review label Jun 23, 2015
@blond
Copy link
Member Author

blond commented Jun 23, 2015

/cc @tormozz48 @sipayRT @tavriaforever

@blond blond mentioned this pull request Jun 23, 2015
Merged
@tavriaforever
Copy link

lgtm
p.s. Do you have any problem without set encoding?

@blond
Copy link
Member Author

blond commented Jun 23, 2015

Do you have any problem without set encoding?

Yes, if you do not specify the encoding in the result will be a Buffer, not a String.

@sipayRT
Copy link

sipayRT commented Jun 24, 2015

👍

@blond blond self-assigned this Jun 24, 2015
blond added a commit that referenced this pull request Jun 24, 2015
@blond
Merge pull request #2 from enb-make/fix-get-content
a91b873 
Fixed `runTechAndGetContent` method: use `utf-8`
@blond blond merged commit a91b873 into master Jun 24, 2015
@blond blond removed the review label Jun 24, 2015
@blond blond deleted the fix-get-content branch June 24, 2015 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blond blond

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blond @tavriaforever @sipayRT