Support for custom CSS techs #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blond
requested changes
Sep 22, 2016
There was a problem hiding this comment.
Не хватает явного переопределения опций про то, откуда взять файлы и куда записать результат.
Смотри пример:
enb-bem-specs/lib/node-configurator.js
Lines 62 to 65 in 40496ad
Т.к. раньше использовалась конкретная технология это было не обязательно.
Разные технологии могут иметь разные дефолтные значения.
40496ad to
05493d1
Compare
|
🆙 |
blond
requested changes
Sep 23, 2016
| @@ -42,17 +42,19 @@ | |||
| "enb": ">= 0.13.0 < 2.0.0", | |||
| "enb-bh": "1.2.0", | |||
| "enb-magic-factory": ">= 0.3.0 < 1.0.0", | |||
| "enb-postcss": "^1.1.0", | |||
| "eslint": "2.5.3", | ||
| "eslint-config-pedant": "0.1.1", | ||
| "jscs": "1.11.0" | ||
| "jscs": "1.11.0", | ||
| "postcss-import": "^8.1.2" |
| @@ -207,7 +211,7 @@ exports.configure = function (config, options) { | |||
| } | |||
|
|
|||
| // CSS | |||
| nodeConfig.addTech(css); | |||
| nodeConfig.addTech([cssEngine.tech, _.assign({}, cssEngine.options, { target: '?.css' })]); | |||
There was a problem hiding this comment.
filesTarget: '?.files' тоже надо закрепить. Если кто-то передаст другое значение, то сборка сломается.
05493d1 to
d254444
Compare
blond
approved these changes
Sep 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.