Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support fot omitting code of module system #46

Merged
merged 1 commit into from
Jan 19, 2016

Conversation

iniel
Copy link

@iniel iniel commented Oct 20, 2015

There's another open PR on this issue (#45), this one brings it up-to-date with the latest module changes.

@levonet levonet added the review label Oct 20, 2015
@arikon
Copy link
Member

arikon commented Oct 21, 2015

/cc @blond

@@ -144,7 +144,7 @@ exports.configure = function (config, options) {
target: '?.pure.ym.js',
sourceSuffixes: [],
filesTarget: '?.base.files',
includeYM: true
includeYM: !options.omitModules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you, please, rename this option to includeYM with default value true.

@blond blond added ready and removed review labels Dec 17, 2015
@blond
Copy link
Member

blond commented Jan 14, 2016

@iniel, ping?

@iniel iniel force-pushed the support-for-omitting-modules branch 2 times, most recently from 21a4477 to 67b884f Compare January 18, 2016 09:30
@iniel
Copy link
Author

iniel commented Jan 19, 2016

@blond, updated.

@blond
Copy link
Member

blond commented Jan 19, 2016

@iniel need rebase onto master branch.

@iniel iniel force-pushed the support-for-omitting-modules branch from 67b884f to fa61694 Compare January 19, 2016 09:32
@iniel
Copy link
Author

iniel commented Jan 19, 2016

@blond, rebased.

@blond
Copy link
Member

blond commented Jan 19, 2016

👍

blond added a commit that referenced this pull request Jan 19, 2016
Added support fot omitting code of module system
@blond blond merged commit 1d2a593 into enb:master Jan 19, 2016
@blond blond removed the ready label Jan 19, 2016
@blond blond added this to the 0.9.0 milestone Apr 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants