Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal Coding Standards #2

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Drupal Coding Standards #2

merged 1 commit into from
Jun 7, 2024

Conversation

codechefmarc
Copy link
Collaborator

@codechefmarc codechefmarc commented Apr 19, 2024

Summary

This PR fixes/implements the following bugs/features

  • Checked the code against phpcs with the Drupal standard and refactored the following
  • Added dependency injection to the SubThemeCommands for 3 services
  • Moved SubThemeGenerator to a service
  • Cleaned up unused use statements

Explain the motivation for making this change. What existing problem does the pull request solve?

Prepares the module for Drupal.org and best coding practices.

Documentation update (required)

No changes to documentation, command works exactly the same way as before.

How to review this pull request

  • Pull down this repo into the /web/modules/contrib directory and switch to this branch
  • Pull down the emulsify_drupal repo into the /web/themes/contrib directory and switch to the release-base-theme branch.
  • Enable the Emulsify Tools module - drush en emulsify_tools
  • Run the command drush emulsify my_awesome_theme
  • Verify that a new sub theme is generated in /web/themes/custom/my_awesome_theme

Copy link
Collaborator

@callinmullaney callinmullaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codechefmarc codechefmarc merged commit e7213f0 into main Jun 7, 2024
1 check passed
@codechefmarc codechefmarc deleted the initial-test-fixes branch June 7, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants