added dhw alternating operation

[pswid]

In the thermostat menu options look like this:

[MichaelDvP]

I see the intension to add "OFF" to the bool input with pl language, but we have to keep the toLower(value) to match all mixed case writings like "True", "On".
Please re-add bool_str = toLower(value) and change in the if's to bool_str == toLower(Helpers::translated_word(FL_(OFF)) then all options should work.

[pswid]

Done. Sorry for delay. It works but I noticed that toLower() and toUpper() do not work on Polish characters (ĄĘĆŁŃÓŚŹŻ). It should be fixed but I don't know how. I read somewhere that locale needs to be set properly.

[MichaelDvP]

I think you have to check the special charcater here explicide:

EMS-ESP32/src/helpers.cpp

Line 665 in 88404bc

std::transform(lc.begin(), lc.end(), lc.begin(), [](unsigned char c) { return std::tolower(c); });

[pswid]

toupper() is used e.g. here:

EMS-ESP32/src/mqtt.cpp

Line 1135 in 88404bc

F_name[0] = toupper(F_name[0]); // capitalize first letter

and it doesn't work. The first letter of HA friendy names starting with Polish character is not capitalized (e.g. "łączny czas grzania"), so I assume that std::tolower() will not work also.

[MichaelDvP]

Yes the std::tolower only converts A-Z. I thought of something like a Helpers::tolower:
(i have not tested if it works)

int Helpers::tolower(int _c) {
    switch (_c) {
    case 'Ż': return 'ż';
    // insert other special characters here
    default: return std::tolower(_c);
    }
}

std::string Helpers::toLower(std::string const & s) {
    std::string lc = s;
    std::transform(lc.begin(), lc.end(), lc.begin(), [](unsigned char c) { return tolower(c); }); // use own tolower() here
    return lc;
}

[proddy]

Yes the std::tolower only converts A-Z. I thought of something like a Helpers::tolower: (i have not tested if it works)

int Helpers::tolower(int _c) {
    switch (_c) {
    case 'Ż': return 'ż';
    // insert other special characters here
    default: return std::tolower(_c);
    }
}

std::string Helpers::toLower(std::string const & s) {
    std::string lc = s;
    std::transform(lc.begin(), lc.end(), lc.begin(), [](unsigned char c) { return tolower(c); }); // use own tolower() here
    return lc;
}

that would work. Or just don't bother with toLower/Upper because of the different charsets. I don't think we'll miss much.

[pswid]

I wouldn't want special characters to be ignored. This can cause various problems in other places, especially if more languages using special characters will be added in the future.

The main cause of problems with special characters (e.g. Polish letters) is due to the fact that in UTF-8 they are not encoded in 1 byte, but in 2 bytes (in UTF-8 there are characters that require even 4 bytes!).

My commit 4f05dda doesn't "break" anything, but fixes a bug with the boolean "wł./wył." option, so I think it can be merged (and possibly improved in the future).

Since there are currently no entities starting in Polish with a special character other than "ł", temporary solution could by replacing

EMS-ESP32/src/mqtt.cpp

Line 1135 in 88404bc

F_name[0] = toupper(F_name[0]); // capitalize first letter

by:

    if (F_name[0] == 0xC5 && F_name[1] == 0x82)  //if first letter is Polish "ł" (UTF-8: 0xC5 0x82)...
        F_name[1] = 0x81;   //change it to "Ł" (UTF-8: 0xC5 0x81)
    else
        F_name[0]     = toupper(F_name[0]); // capitalize first letter

Ultimately, however, own toupper & tolower procedures should be created that will also work with special characters (are not based on 8-bit variables such as char).

[MichaelDvP]

You can change this to match more special characters to:

        // grave, acute, circumflex, diaeresis, etc.
        if ((*(c + 1) >= 0xA0) && (*(c + 1) <= 0xBE)) {
            *(c + 1) -= 0x20;
        }

[proddy]

when this is done I'll merge

[pswid]

done. sorry for the delay

[proddy]

thanks!

[proddy]

ok to merge @MichaelDvP ?

[MichaelDvP]

Yes.