Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to enable multiple instances using a flag #793

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Conversation

proddy
Copy link
Contributor

@proddy proddy commented Dec 6, 2022

No description provided.

@proddy
Copy link
Contributor Author

proddy commented Dec 6, 2022

I noticed the system MQTT topics may need to always be prefixed with the base. I'll check how it looks like in 3.4 and make sure its backwards compatible.

@proddy
Copy link
Contributor Author

proddy commented Dec 6, 2022

I noticed the system MQTT topics may need to always be prefixed with the base. I'll check how it looks like in 3.4 and make sure its backwards compatible.

I checked with 3.4 and also b10 and none of the system MQTT discovery topics had the ems-esp prefixed, which is odd and probably wrong since a Home Assistant entity like sensor.system_uptime is a bit ambiguous. We can consider changing it later.

I'm going to merge the PR now as I'm worried people will install this b11 and mess up their HA

@proddy proddy merged commit abeef2b into emsesp:dev Dec 6, 2022
@MichaelDvP
Copy link
Contributor

Nice idea to keep backward compatibility.
But it's an option only affects HA discovery, isn't it better to place the checkbox to HA section like this (and hide with HA disabled):
grafik

@proddy
Copy link
Contributor Author

proddy commented Dec 7, 2022

Yeah. I thought about that too after I implemented it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants