-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Moduline 400 WW settings and timer clock program #467
Conversation
…ertie01/EMS-ESP32 into feature/moduline400WWandTimer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
While checking i've seen some old bugs: the RC20 also uses T1-T4, but masks wrong with & 1
when reading and set_switchtemp checks input to max 3 instead of 4. I 'll fix this later, or, if you like, you can add to this PR.
I'm a little bit ashamed and must admit that I didn't test the set_switchtemp properly. You are right that this is not working correctly now. I can set it using a number <3 but not using the letter T in front and/or number 4. |
@MichaelDvP you can approve the Merge request if you're fine with the additions. |
@MichaelDvP The (old) bug of the RC20 mask and the set_switchtemp for the RC30 are fixed. |
Thanks, only one remark: |
I saw your remark too late and already created the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, @proddy: i don't have more remarks, please merge.
done! nice work chaps |
In this PR I added new features for the Moduline 400 Thermostat.
I added 5 parameters of the 0x3A telegram from the Moduline 400 (RC30) thermostat. (RC30wwSettings)
I added 7 parameters of the 0x40 telegram from the Moduline 400 (RC30) thermostat. (RC30Temp)
Added reading/writing of the switch points (switchtime1) of the Moduline 400 (RC30) clock program (0x3F telegram) including the following parameters: