adapt limits #302
Merged
adapt limits #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proddy
reviewed
Jan 18, 2022
src/emsdevice.cpp
Outdated
| @@ -1070,9 +1070,10 @@ bool EMSdevice::get_value_info(JsonObject & output, const char * cmd, const int8 | |||
|
|
|||
| json["writeable"] = dv.has_cmd; | |||
| // if we have individual limits, overwrite the common limits | |||
| // limits are not scaled with divider and temperatures are °C | |||
| if (dv.min != 0 || dv.max != 0) { | |||
There was a problem hiding this comment.
as this overrides the previous json[min] & json[max] assignments is there not a more efficient way of doing this? It's a costly operation
There was a problem hiding this comment.
For now we have only 2 or 3 values with stored limits. It's a lot of work to examine all the limits. We can use a bool and check this for all limit settings.
There was a problem hiding this comment.
ok. ArduinoJSON can be a pig sometimes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.