updates to 3.7.1 #2154
Merged
updates to 3.7.1 #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDvP
reviewed
Oct 30, 2024
| @@ -133,7 +133,7 @@ class Telegram { | |||
| auto msg_size = (index - this->offset + num_bytes - 1); | |||
|
|
|||
| if ((index < this->offset) || (msg_size >= this->message_length) || (msg_size > EMS_MAX_TELEGRAM_MESSAGE_LENGTH)) { | |||
| return false; | |||
| return false; // TODO we should set value to a default value here | |||
There was a problem hiding this comment.
No!, we often get only parts of a telegram. If a value is not in this part (offset/length) we don't want to change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor updates to comments and doc.
I created a data folder. So when you add a file called
pre_load.json, doing apio run -e s3_16M_P -t uploadfs(example) will pre-install some user settings.