Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose EMS-ESP commands (like reset) via MQTT Discovery #1605 #1626

Merged
merged 9 commits into from
Feb 22, 2024
Merged

Expose EMS-ESP commands (like reset) via MQTT Discovery #1605 #1626

merged 9 commits into from
Feb 22, 2024

Conversation

proddy
Copy link
Contributor

@proddy proddy commented Feb 20, 2024 •
edited
Loading

All CMDs are treated as ENUMs

and

Send MQTT heartbeat immediately after connection #1628

@proddy proddy requested a review from MichaelDvP February 21, 2024 22:05
MichaelDvP
MichaelDvP reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@MichaelDvP MichaelDvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me (but i don't know what HA shows).

@proddy
Copy link
Contributor Author

proddy commented Feb 22, 2024

Looks ok to me (but i don't know what HA shows).

as a select list in the HA UI

image

@proddy proddy merged commit c769fd6 into emsesp:dev Feb 22, 2024
@MichaelDvP MichaelDvP mentioned this pull request Feb 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDvP MichaelDvP MichaelDvP left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proddy @MichaelDvP