Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the test.mosquitto.org URL in the MQTT settings #829

Closed
bbqkees opened this issue Dec 23, 2022 · 4 comments
Closed

Remove the test.mosquitto.org URL in the MQTT settings #829

bbqkees opened this issue Dec 23, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@bbqkees
Copy link
Contributor

bbqkees commented Dec 23, 2022

In the MQTT settings, by default the host address is test.mosquitto.org.

I often get emails from customers who have issues with MQTT and then the result after some questions about their configuration is that they are actually using test.mosquitto.org as the MQTT broker.

If we remove the default URL here then they are forced to think one step further and fill out the IP of their actual local broker.

@bbqkees bbqkees added the enhancement New feature or request label Dec 23, 2022
@proddy proddy added this to the v3.5.0 milestone Dec 23, 2022
@proddy
Copy link
Contributor

proddy commented Dec 23, 2022

ok, need to see how to do this as the value can't be blank.

@bbqkees
Copy link
Contributor Author

bbqkees commented Dec 23, 2022

I think there are lots of users who are actually using the test server, not just those who send an email with an issue.
So we need to protect them from this insecure solution.

Maybe just use 0.0.0.0?
Or when they tick the 'Enable MQTT' tickbox make the host box empty?

@proddy
Copy link
Contributor

proddy commented Dec 23, 2022

I have a solution now.

@proddy proddy self-assigned this Dec 23, 2022
proddy added a commit to proddy/EMS-ESP32 that referenced this issue Dec 23, 2022
@bbqkees
Copy link
Contributor Author

bbqkees commented Dec 23, 2022

Ok thanks.

@bbqkees bbqkees closed this as completed Dec 23, 2022
proddy added a commit that referenced this issue Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants