Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller data is showing up in WebUI customization #522

Closed
proddy opened this issue May 26, 2022 · 4 comments
Closed

Controller data is showing up in WebUI customization #522

proddy opened this issue May 26, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@proddy
Copy link
Contributor

proddy commented May 26, 2022

@MichaelDvP

with the addition of 0x06/RCTime being added to the Controller device object everyone will now see this pop up in the Customization page like:

image

although it will never show in up the Web Dashboard, MQTT/API or Console.

Any ideas on how to prevent it showing? e.g. just ignore the Controller type in the Customization or only add this device entity if the boiler type is IVT ?

@proddy proddy added the question Question about something label May 26, 2022
@proddy proddy assigned proddy and MichaelDvP and unassigned proddy May 26, 2022
@proddy proddy changed the title Controller showing in WebUI customization Controller data is showing up in WebUI customization May 26, 2022
@MichaelDvP
Copy link
Contributor

It is shown in dashoard for IVT, if it have a value

if (emsdevice && (emsdevice->device_type() != EMSdevice::DeviceType::CONTROLLER || emsdevice->count_entities() > 0)) {

If you don't like it in customizations, maybe dont show devices with no active entities. But the customization shows all registered values, it's consequent to show the controller value too.

@proddy
Copy link
Contributor Author

proddy commented May 26, 2022

There is logic in boiler and thermostat to only register the entities that are supported on that particular hardware. This is what the device flags are used for. I think we should do the same for the Controller.

@MichaelDvP
Copy link
Contributor

Yes, it's only the IVT controller, i'll add a model-flag.

MichaelDvP added a commit to MichaelDvP/EMS-ESP32 that referenced this issue May 26, 2022
MichaelDvP added a commit to MichaelDvP/EMS-ESP32 that referenced this issue May 26, 2022
proddy added a commit that referenced this issue May 26, 2022
@proddy proddy added this to the v3.4.1 milestone May 27, 2022
@proddy
Copy link
Contributor Author

proddy commented May 27, 2022

fixed in 3.4.1

@proddy proddy closed this as completed May 27, 2022
@proddy proddy reopened this Feb 19, 2023
@proddy proddy added enhancement New feature or request and removed question Question about something labels Feb 19, 2023
@proddy proddy closed this as completed Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants