Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastheatupfactor - detailled info missing in api V3. #122

Closed
tp1de opened this issue Sep 20, 2021 · 12 comments
Closed

fastheatupfactor - detailled info missing in api V3. #122

tp1de opened this issue Sep 20, 2021 · 12 comments
Labels
bug Something isn't working

Comments

@tp1de
Copy link
Contributor

tp1de commented Sep 20, 2021

ems-esp/api/thermostat/hc1/fastheatupfactor returns

{
"message": "Problems parsing elements"
}

uom should be %. min = 0 / max = 100.

BTW: API V3 changed from unit into uom ..... I need to adjust my ioBroker adapter. Please do not change without need.

@tp1de tp1de added the bug Something isn't working label Sep 20, 2021
@proddy
Copy link
Contributor

proddy commented Sep 20, 2021

unit is the wrong English word. And the dev branch is for changes. Any breaking changes will be documented between the official versions. If it bothers you stick to the main branch

@proddy
Copy link
Contributor

proddy commented Sep 20, 2021

what does http://ems-esp/api/thermostat/hc1 come back with?

@tp1de
Copy link
Contributor Author

tp1de commented Sep 20, 2021

what does http://ems-esp/api/thermostat/hc1 come back with?

{
  "seltemp": 22,
  "currtemp": 22.9,
  "mode": 1,
  "modetype": 1,
  "ecotemp": 19,
  "manualtemp": 16,
  "comforttemp": 22,
  "summertemp": 16,
  "designtemp": 42,
  "offsettemp": 0,
  "minflowtemp": 35,
  "maxflowtemp": 55,
  "roominfluence": 0,
  "nofrosttemp": -5,
  "targetflowtemp": 0,
  "heatingtype": 1,
  "summersetmode": 0,
  "summermode": 1,
  "controlmode": 1,
  "program": 1,
  "fastheatupfactor": 20
}

@tp1de
Copy link
Contributor Author

tp1de commented Sep 20, 2021

unit is the wrong English word.

maybe ... but in ioBroker it is since years unit as well.

And the dev branch is for changes. Any breaking changes will be documented between the official versions.

Just tell me how to track changes within API V3 so that I can adjust accordingly.
Can't you inform ahead within discord channel DEVELOPMENT/api?

@proddy
Copy link
Contributor

proddy commented Sep 20, 2021

Can't you inform ahead within discord channel DEVELOPMENT/api?

that's a good idea. I do agree it needs to be listed somewhere. It should be highlighted in the changelog but often we (I) forget

@proddy
Copy link
Contributor

proddy commented Sep 20, 2021

Ok I found a number of errors in the API which I fixed in another branch, so will need to merge later. For example http://ems-esp/api/boiler/id would cause EMS-ESP to crash and restart. not good!

@MichaelDvP
Copy link
Contributor

MichaelDvP commented Sep 21, 2021

If "fastheatupfactor" is a percentage value, it is not a factor. Factors are scalar values, percentage is a relation to a reference scaled to 100. I've renamed to fastheatup and added the percent.

Parsing does not work because hc1/fastheatupfactor was one byte to long for the parsing-buffer.

PS: @proddy Other value-names like cylinderpumpmodulationare also to long, i've enlarged the buffer. But long names also blowing up mqtt and api response, especially if in a heatingcircuit.

@MichaelDvP
Copy link
Contributor

For example http://ems-esp/api/boiler/id would cause EMS-ESP to crash and restart. not good!

Working for me, i think it crashes in the new EMSdevice::device_entity_ha(, which does not check for fullname == nullptr.

@proddy
Copy link
Contributor

proddy commented Sep 21, 2021

yes it only crashes when HA is enabled. I've made the fixes, just in another branch so will merge later along with some React Hooks modifications

@tp1de
Copy link
Contributor Author

tp1de commented Sep 21, 2021

if "fastheatupfactor" is a percentage value, it is not a factor. Factors are scalar values, percentage is a relation to a reference scaled to 100. I've renamed to fastheatup and added the percent.

Nevertheless the km200 field-name is even with percentage fastHeatupFactor

@MichaelDvP
Copy link
Contributor

Nevertheless the km200 field-name is even with percentage fastHeatupFactor

I know, the name was taken from here, but it was not mentioned that it is a percent value. If Bosch names are wrong we don't need to copy them.

@proddy
Copy link
Contributor

proddy commented Sep 22, 2021

fixed in latest dev. re-open if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants