add TODO on possible memory out-of-bounds error

emsesp · Sep 23, 2023 · 917e268 · 917e268
1 parent 41228e8
commit 917e268
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/devices/thermostat.cpp b/src/devices/thermostat.cpp
@@ -843,6 +843,8 @@ void Thermostat::process_RC35wwTimer(std::shared_ptr<const Telegram> telegram) {
     if (telegram->type_id != 0x38) {
         return;
     }
+
+    // TODO: should this be >= 87 to avoid out of bounds?
     if (telegram->message_length + telegram->offset >= 92 && telegram->offset <= 87) {
         char data[sizeof(wwVacation_)];
         snprintf(data,