Elf sections size check before flashing #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the addition of new codecs and applications, code size grew to overwrite the part of FRAM currently used to store card slots (settings). This simple (although hacky) makefile command verifies if such an issue will occur before flashing the firmware.
Had to make some minor changes to Commands.c and CommandLine.c to allow building without these codecs
This was referenced Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lately some issues have been popping up in both this repo #281 and RRG RfidResearchGroup#43. I also faced similar "randomic" issues but initially discarded them as unlucky flash.
When investigating the issue, @fptrs pointed me in the right direction and all these issues were due to code being written in the FRAM section used to store card configs. @maxieds opened an issue (#283) to confront on the best way to properly solve this problem, but I believe checking memory usage might be useful in any case.
I have tested this code on both linux and windows (cygwin basic install)