Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError noticed in conda-forge release #114

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

agriyakhetarpal
Copy link
Contributor

@agriyakhetarpal agriyakhetarpal commented Jan 27, 2025

I guess this is what we need to fix the error noticed in conda-forge/empack-feedstock#62?

That said, I don't see why the error is being raised in the first place, because it's using Python 3.12, which supports writing unions with | instead of having to use Union[<...>, <...>]

Ah, right, because Python 3.12 is just the conda-build driver version

@agriyakhetarpal agriyakhetarpal changed the title Fix TypeError Fix TypeError noticed in conda-forge release Jan 27, 2025
@martinRenou martinRenou added the bug Something isn't working label Jan 28, 2025
Copy link
Contributor

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 2bb1b23 into emscripten-forge:main Jan 28, 2025
4 of 5 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix/type-error branch January 28, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants