Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic rebaseline of codesize expectations. NFC #23370

Closed
wants to merge 1 commit into from

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Jan 10, 2025

Running rebaseline_tests.py on main branch caused this change.

This is an automatic change generated by tools/maint/rebaseline_tests.py.

The following (13) test expectation files were updated by running the tests with --rebaseline:

other/codesize/test_codesize_cxx_ctors1.size: 129218 => 129211 [-7 bytes / -0.01%]
other/codesize/test_codesize_cxx_ctors2.size: 128630 => 128623 [-7 bytes / -0.01%]
other/codesize/test_codesize_cxx_except.size: 170886 => 170879 [-7 bytes / -0.00%]
other/codesize/test_codesize_cxx_except_wasm.size: 142169 => 142162 [-7 bytes / -0.00%]
other/codesize/test_codesize_cxx_except_wasm_exnref.size: 144715 => 144708 [-7 bytes / -0.00%]
other/codesize/test_codesize_cxx_mangle.size: 232731 => 232724 [-7 bytes / -0.00%]
other/codesize/test_codesize_cxx_noexcept.size: 131781 => 131774 [-7 bytes / -0.01%]
other/codesize/test_codesize_cxx_wasmfs.size: 169188 => 169181 [-7 bytes / -0.00%]
other/codesize/test_codesize_hello_O0.size: 15113 => 15101 [-12 bytes / -0.08%]
other/codesize/test_codesize_minimal_pthreads.size: 19405 => 19394 [-11 bytes / -0.06%]
other/test_unoptimized_code_size.wasm.size: 15113 => 15101 [-12 bytes / -0.08%]
other/test_unoptimized_code_size_no_asserts.wasm.size: 12194 => 12182 [-12 bytes / -0.10%]
other/test_unoptimized_code_size_strict.wasm.size: 15113 => 15101 [-12 bytes / -0.08%]

Average change: -0.03% (-0.10% - -0.00%)

Running `rebaseline_tests.py` on `main` branch caused this change.

This is an automatic change generated by tools/maint/rebaseline_tests.py.

The following (13) test expectation files were updated by
running the tests with `--rebaseline`:

```
other/codesize/test_codesize_cxx_ctors1.size: 129218 => 129211 [-7 bytes / -0.01%]
other/codesize/test_codesize_cxx_ctors2.size: 128630 => 128623 [-7 bytes / -0.01%]
other/codesize/test_codesize_cxx_except.size: 170886 => 170879 [-7 bytes / -0.00%]
other/codesize/test_codesize_cxx_except_wasm.size: 142169 => 142162 [-7 bytes / -0.00%]
other/codesize/test_codesize_cxx_except_wasm_exnref.size: 144715 => 144708 [-7 bytes / -0.00%]
other/codesize/test_codesize_cxx_mangle.size: 232731 => 232724 [-7 bytes / -0.00%]
other/codesize/test_codesize_cxx_noexcept.size: 131781 => 131774 [-7 bytes / -0.01%]
other/codesize/test_codesize_cxx_wasmfs.size: 169188 => 169181 [-7 bytes / -0.00%]
other/codesize/test_codesize_hello_O0.size: 15113 => 15101 [-12 bytes / -0.08%]
other/codesize/test_codesize_minimal_pthreads.size: 19405 => 19394 [-11 bytes / -0.06%]
other/test_unoptimized_code_size.wasm.size: 15113 => 15101 [-12 bytes / -0.08%]
other/test_unoptimized_code_size_no_asserts.wasm.size: 12194 => 12182 [-12 bytes / -0.10%]
other/test_unoptimized_code_size_strict.wasm.size: 15113 => 15101 [-12 bytes / -0.08%]

Average change: -0.03% (-0.10% - -0.00%)
```
@aheejin aheejin requested review from sbc100 and brendandahl January 10, 2025 21:40
@aheejin
Copy link
Member Author

aheejin commented Jan 10, 2025

Huh the CI says the current expectations are up to date... Weird

@aheejin
Copy link
Member Author

aheejin commented Jan 10, 2025

Turns out I was using LLVM tot (not the pinned version at the moment)... Closing. Thanks @brendandahl

@aheejin aheejin closed this Jan 10, 2025
@aheejin aheejin deleted the rebaseline branch January 10, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant