Remove unused isPowerOfTwo function from JS compiler. NFC #23353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add `utf8` to read function to avoid the extra `toString()` call (which itself defaults to `utf8`).
kripken
reviewed
Jan 9, 2025
| @@ -231,13 +231,9 @@ export function isDecorator(ident) { | |||
| return suffixes.some((suffix) => ident.endsWith(suffix)); | |||
| } | |||
|
|
|||
| export function isPowerOfTwo(x) { | |||
| return x > 0 && (x & (x - 1)) == 0; | |||
| } | |||
There was a problem hiding this comment.
This may be used by user JS libraries - is it worth removing? If so, let's at least mention in the changelog?
There was a problem hiding this comment.
No, the way these "exports" work is only to other ES6 modules that make up the compiler.
The JS libraries don't have visibility of these symbols, by design. JS libraries can only see symbols that are explictly added using addToCompileTimeContext. This function (isPowerOfTwo) is not one of those.
There was a problem hiding this comment.
Oh, nice, I wasn't aware that ES6 modules limited things that way.
kripken
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add
utf8to read function to avoid the extratoString()call (which itself defaults toutf8).