Keep the endianness check when assertions are off for node #22391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js has a big-endian s390 version which occasionally turns up; silent failure of an emscripten module used in a JavaScript library can be hard to debug. Disabling node output and assertions will keep the check off. If the check sees a big-endian system, it will throw an error during initialization and this will be visible in debug logging, letting the affected downstream users know what's wrong and how they might fix or work around it. Helps with: emscripten-core#12387
kripken
reviewed
Aug 22, 2024
| // Endianness check | ||
| #if !SUPPORT_BIG_ENDIAN | ||
| // Note that s390 node *occasionally* pops up and is big-endian. |
There was a problem hiding this comment.
How about this?
Suggested change
| // Note that s390 node *occasionally* pops up and is big-endian. | |
| // Note that s390 node *occasionally* pops up and is big-endian, so we check for | |
| // endianness when node is enabled, even when assertions are off (no browser | |
| // platform is big-endian AFAWCT, so we don't do that on web-only builds, to | |
| // save size there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js has a big-endian s390 version which occasionally turns up; silent failure of an emscripten module used in a JavaScript library can be hard to debug.
Disabling node output and assertions will keep the check off. If the check sees a big-endian system, it will throw an error during initialization and this will be visible in debug logging, letting the affected downstream users know what's wrong and how they might fix or work around it.
Helps with: #12387