Mark -sUSE_PTHREADS as legacy in favor of -pthread. NFC
#18923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c00956 to
ba4d01d
Compare
53399d3 to
e7ceb75
Compare
kripken
approved these changes
Mar 8, 2023
Create a new internal setting called just `PTHREADS` and use that everywhere internally. This allows the old setting to be marked as legacy, but still supported in case existing use JS library code uses it.
8766eca to
e6fdc7e
Compare
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
Create a new internal setting called just `PTHREADS` and use that everywhere internally. This allows the old setting to be marked as legacy, but still supported in case existing use JS library code uses it.
impact-maker
pushed a commit
to impact-maker/emscripten
that referenced
this pull request
Mar 17, 2023
Create a new internal setting called just `PTHREADS` and use that everywhere internally. This allows the old setting to be marked as legacy, but still supported in case existing use JS library code uses it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new internal setting called just
PTHREADSand use that everywhere internally.This allows the old setting to be marked as legacy, but still supported in case existing use JS library code uses it.