Fix test_dylink_spaghetti #14921
Merged
Fix test_dylink_spaghetti #14921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was inadvertently relying on an bug in llvm which was recently fixed: #13773 In this test the class `Class` is defined in both the main and the side module. If you run this code as is on the desktop the version of `Class` defined in `main.cpp` will always win the `side init` will never get printed. The fix is to give the class in the side module a different name (and alternative would be to put it in an anonymous namespace). This change should allow the llvm fix to roll in: https://reviews.llvm.org/D108413
dschuff
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was inadvertently relying on an bug in llvm which was recently
fixed: #13773
In this test the class
Classis defined in both the main and the sidemodule. If you run this code as is on the desktop the version of
Classdefined inmain.cppwill always win theside initwill neverget printed.
The fix is to give the class in the side module a different name (and
alternative would be to put it in an anonymous namespace).
This change should allow the llvm fix to roll in:
https://reviews.llvm.org/D108413