fix: re:run does not work with unicode char list #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
approved these changes
Jul 3, 2024
|
thanks for the review. |
keynslug
reviewed
Jul 4, 2024
| @@ -1352,6 +1352,9 @@ default_map_key_name_validator(Name) -> | |||
| end | |||
| end. | |||
|
|
|||
| re_run(Str, Pattern) -> | |||
| re:run(unicode:characters_to_binary(Str, utf8), Pattern). | |||
There was a problem hiding this comment.
Nit. I think the correct way is actually re:run(Str, Pattern, [unicode]). Otherwise the risk is re consuming half of the (encoded) codepoint somewhere, because it still thinks that one byte = one character. Should be okay with current ?MAP_KEY_RE but not too future-proof.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.