Add ComponentType overloading #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5afeb56 to
d4a2aa8
Compare
nickserv
approved these changes
Jul 5, 2018
|
@Ailrun could you fix the merge conflicts? |
d4a2aa8 to
0e3d7ab
Compare
|
@mitchellhamilton I just did it :) |
emmatown
reviewed
Jul 6, 2018
| @@ -24,7 +24,7 @@ export interface StyledComponentMethods<Props extends object, InnerProps extends | |||
| ): StyledStatelessComponent<Props, IP, Theme>; | |||
|
|
|||
| withComponent<IP extends object>( | |||
| component: ComponentClass<IP>, | |||
| component: ComponentClass<IP> | ComponentType<IP>, | |||
There was a problem hiding this comment.
I was just looking at the react types and ComponentType is defined like this
type ComponentType<P = {}> = ComponentClass<P> | StatelessComponent<P>;So couldn't ComponentClass be removed here and the other places which are ComponentClass<IP> | ComponentType<IP>?
There was a problem hiding this comment.
@mitchellhamilton It is also same in Preact, but I thought this is more clear, since this ComponentType<IP> is only for the library code who returns ComponentType<IP> in their code.
emmatown
reviewed
Jul 6, 2018
| @@ -23,7 +23,7 @@ export interface StyledComponentMethods<Props extends object, InnerProps extends | |||
| ): StyledStatelessComponent<Props, IP, Theme>; | |||
|
|
|||
| withComponent<IP extends object>( | |||
| component: ComponentConstructor<IP>, | |||
| component: ComponentConstructor<IP> | ComponentFactory<IP>, | |||
There was a problem hiding this comment.
Same as the previous comment, couldn't this usage and the other just be ComponentFactory<IP>?
https://github.com/developit/preact/blob/master/src/preact.d.ts#L40
emmatown
approved these changes
Jul 6, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Add
ComponentType/ComponentFactorycases to styled function overloadings.Why: #736.
How: By adding function overloadings
Checklist: