Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No duplicated ast nodes #730

Merged
merged 2 commits into from
Jun 18, 2018
Merged

No duplicated ast nodes #730

merged 2 commits into from
Jun 18, 2018

Conversation

Andarist
Copy link
Member

Checklist:

  • Documentation
  • Tests
  • Code complete

fixes #726

@Andarist Andarist force-pushed the no-duplicated-ast-nodes branch from 7875276 to 4ea1682 Compare June 17, 2018 21:56
Andarist
Andarist commented Jun 17, 2018
View reviewed changes
packages/babel-plugin-emotion/test/util.js
@@ -25,38 +26,43 @@ jest.mock('fs')
fs.existsSync.mockReturnValue(true)
fs.statSync.mockReturnValue({ isFile: () => false })

const createInlineTester = transform => opts => {
const isBabel7 = babel => parseInt(babel.version.split('.')[0], 10) === 7
Copy link
Member Author

@Andarist Andarist Jun 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

babel@6 duplicates some nodes, so we just want to validate this when using babel@7 to avoid false positives caused by babel itself

@Andarist Andarist force-pushed the no-duplicated-ast-nodes branch 4 times, most recently from e1576bd to d0d53aa Compare June 17, 2018 22:23
@codecov
Copy link

codecov bot commented Jun 17, 2018 •
edited
Loading

Codecov Report

Merging #730 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/babel-plugin-emotion/src/babel-utils.js 96.87% <100%> (+0.04%) ⬆️
packages/babel-plugin-emotion/test/util.js 100% <100%> (ø) ⬆️

emmatown
emmatown reviewed Jun 18, 2018
View reviewed changes
Copy link
Member

@emmatown emmatown left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test with the macro and the commonjs transform like #726?

@Andarist Andarist force-pushed the no-duplicated-ast-nodes branch from d0d53aa to 936155b Compare June 18, 2018 07:52
@Andarist
Copy link
Member Author

@mitchellhamilton done

emmatown
emmatown approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@emmatown emmatown merged commit 3d8e889 into master Jun 18, 2018
@emmatown emmatown deleted the no-duplicated-ast-nodes branch June 18, 2018 08:55
@Andarist
Copy link
Member Author

@mitchellhamilton as to the registry change - I couldn't install @babel/preset-env yesterday (failing on different packages) from yarn registry. It also seems that yarn's registry might be deprecated in the future - yarnpkg/yarn#5891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown emmatown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Emotion Babel Macro duplicating nodes
2 participants
@Andarist @emmatown