Use emotion-next in the site, update to gatsby v2 and add Community page #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Andarist
reviewed
Jun 13, 2018
| import createBroadcast from './create-broadcast' | ||
| import { channel, contextTypes, type Theme } from './utils' | ||
|
|
||
| const isPlainObject = test => | ||
| Object.prototype.toString.call(test) === '[object Object]' | ||
|
|
||
| type Props = { | ||
| theme: Theme | ||
| theme: Theme, | ||
| children?: ReactNode |
There was a problem hiding this comment.
should this be optional? i get that it's technically possible to use it without children but it also doesn't make sense
…ponent but this'll work for now since i want to get this merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Use emotion-next in the site, update to gatsby v2 and add Community page
Why:
I wanted to see what the migration to emotion@10 will be like
How:
Checklist:
This isn't ready yet, I just wanted to open the PR to get people's thoughts on the Community page