Add TS typings to create-emotion #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78ac40c to
8abeff7
Compare
8abeff7 to
cdcb3fe
Compare
emmatown
reviewed
May 20, 2018
| css([]); | ||
| css([1]); | ||
| css([['abc', 'asdf'], 'efw']); | ||
|
|
There was a problem hiding this comment.
Could you add a test with the string syntax, for example:
css`
color: ${'hotpink'};
`There was a problem hiding this comment.
I added them! Thank you for your feedback!
| | FunctionInterpolation<C> | ||
| ; | ||
|
|
||
| export type FunctionClassNameArg = () => ClassNameArg | void; |
There was a problem hiding this comment.
Could you remove this? We recently deprecated it in #643 so it would be nice to not have it in the typings.
| } | ||
| export interface CSSObject<C> extends CSSBaseObject, CSSPseudoObject<C>, CSSOthersObject<C> {} | ||
|
|
||
| export type FunctionInterpolation<C> = (mergedProps: any, context: C) => Interpolation<C> | void; |
There was a problem hiding this comment.
Same as above. We recently deprecated it in #643 so it would be nice to not have it in the typings.
emmatown
approved these changes
May 20, 2018
|
@mitchellhamilton Could I ask about release schedule? When will this be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Add typings for create-emotion package
Why: To make TS user be able to use create-emotion package.
How: Using csstype package, who crawls css data from MDN.
Checklist:
I'm willing to add more strict typing (and the typing providing helpful autocompletions) for emotion package, but I think I should add typings for create-emotion, to avoid repeated code and revesed dependencies between typings.