Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow labels to be composed #609

Merged
merged 3 commits into from
Apr 2, 2018
Merged

Allow labels to be composed #609

merged 3 commits into from
Apr 2, 2018

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Mar 31, 2018

What:
Allow labels to be composed

Why:
So that labels compose just like styles and you can see what a class name was composed from.
Closes #608

How:
Store the styles on the registered cache before the label declarations are removed.

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@codecov
Copy link

codecov bot commented Mar 31, 2018

Codecov Report

Merging #609 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/create-emotion/src/index.js 100% <100%> (ø) ⬆️

Copy link
Member

@tkh44 tkh44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Nice! LGTM

@tkh44 tkh44 merged commit 2c47f77 into master Apr 2, 2018
@tkh44 tkh44 deleted the compose-labels branch April 2, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: does the babel plugin apply labels to cx?
2 participants