Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SSR with multiple createEmotion calls with the same context #605

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Fix SSR with multiple createEmotion calls with the same context #605

merged 1 commit into from
Mar 23, 2018

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Mar 21, 2018 •
edited
Loading

What:
Fix SSR with multiple createEmotion calls with the same context

Why:
Closes #603

How:
Store the emotion instance instead of the caches on the context object.

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@codecov
Copy link

codecov bot commented Mar 21, 2018 •
edited
Loading

Codecov Report

Merging #605 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/create-emotion/src/index.js 100% <100%> (ø) ⬆️

@emmatown emmatown requested a review from tkh44 March 21, 2018 08:03
@emmatown emmatown merged commit 65fac47 into master Mar 23, 2018
@emmatown emmatown deleted the fix-ssr-with-multiple-create-emotion-calls-with-the-same-context branch March 23, 2018 02:33
@whmountains
Copy link

This is awesome 🎉 When can we expect a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkh44 tkh44 Awaiting requested review from tkh44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSR doesn't work with multiple emotion instances.
2 participants
@emmatown @whmountains