Added TypeScript definitions for css prop. #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On seconds thoughts, maybe this should go into the dts files in the What do you think? |
|
It should go in the react-emotion package I think. |
tkh44
reviewed
Oct 19, 2017
| @@ -3,6 +3,12 @@ import { Interpolation as EmotionInterpolation } from 'emotion' | |||
|
|
|||
| export * from 'emotion' | |||
|
|
|||
| declare module 'react' { | |||
| interface HTMLAttributes<T> { | |||
| css?: string; | |||
There was a problem hiding this comment.
Anything of type Interpolation?
|
I'm using react + emotion without react-emotion so it would be useful to be in the emotion package. |
|
I agree. @cameron-martin. I misread your original comment. Sorry about that. |
66ea2d7 to
80e54df
Compare
|
I've made the css prop take anything of type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added TypeScript definitions for the
cssprop which is compiled toclassNameby the babel plugin.Why:
Because otherwise TypeScript users will get type errors when using this feature.
How:
Used module augmentation/declaration merging to add the
cssproperty to theHTMLAttributesinferface.Checklist: