Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stylis-plugin-emotion and use stylis-rule-sheet #406

Merged
merged 5 commits into from
Oct 14, 2017

Conversation

emmatown
Copy link
Member

What:
Remove stylis-plugin-emotion and use stylis-rule-sheet

Why:
It makes pseudo selector prefixing work, keyframes prefixing without extra stuff in the plugin and it fixes basically all insertion order edge cases.

How:

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@codecov
Copy link

codecov bot commented Oct 14, 2017

Codecov Report

Merging #406 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/emotion/src/index.js 100% <100%> (ø) ⬆️

@emmatown emmatown requested a review from tkh44 October 14, 2017 03:58
@emmatown emmatown merged commit bedbe68 into master Oct 14, 2017
@emmatown emmatown deleted the stylis-rule-sheet branch October 14, 2017 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants