Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract insertion plugin into stylis-plugin-emotion #391

Merged
merged 11 commits into from
Oct 8, 2017

Conversation

tkh44
Copy link
Member

@tkh44 tkh44 commented Oct 8, 2017

What:
Extract stylis-plugin-emotion from emotion.

Why:
Share this effort with other libraries.
I said I would styled-components/styled-components#1208 (comment)

How:
Copy paste mostly.

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

cc @mxstbr

@tkh44 tkh44 requested a review from emmatown October 8, 2017 05:01
Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesssssss thank you!

/cc @schwers

@codecov
Copy link

codecov bot commented Oct 8, 2017

Codecov Report

Merging #391 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/stylis-plugin-emotion/src/index.js 100% <100%> (ø)
packages/emotion/src/index.js 100% <100%> (ø) ⬆️

@emmatown emmatown changed the title stylis-plugin-emotion Extract insertion plugin into stylis-plugin-emotion Oct 8, 2017
@tkh44 tkh44 merged commit dafab02 into master Oct 8, 2017
@tkh44 tkh44 deleted the stylis-plugin-emotion branch October 8, 2017 05:48
@tkh44
Copy link
Member Author

tkh44 commented Oct 8, 2017

Released in v8.0.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants