Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert empty rule in dev #1997

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Insert empty rule in dev #1997

merged 2 commits into from
Sep 8, 2020

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Sep 5, 2020

This reverts #1962 as it has found to be problematic with sites using CSP. An alternative fix for the previously fixed issue has been implemented. It's best to just review this commit: 36e3e91

This fixes #1993

This reverts commit dc1a0c5.

# Conflicts:
#	packages/css/test/__snapshots__/component-selector.test.js.snap
@Andarist Andarist requested a review from emmatown September 5, 2020 12:02
@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2020

🦋 Changeset is good to go

Latest commit: 36e3e91

We got this.

This PR includes changesets to release 6 packages
Name Type
@emotion/cache Patch
@emotion/sheet Patch
@emotion/css Patch
@emotion/react Patch
@emotion/jest Patch
@emotion/server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 36e3e91:

Sandbox Source
Emotion Configuration
@emotion/sheet 11 CSP nonce issue Issue #1993

@Andarist Andarist merged commit 39be057 into next Sep 8, 2020
@Andarist Andarist deleted the insert-empty-rule-in-dev branch September 8, 2020 11:01
@github-actions github-actions bot mentioned this pull request Sep 8, 2020
@github-actions github-actions bot mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants