Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid transpiling vanilla emotion calls in already transpiled code to avoid double labels and such #1602

Merged
merged 1 commit into from
Nov 3, 2019

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Nov 3, 2019

Fixes #1328

I've decided to target next with this as it's a minor thing and it's better to avoid potential conflicts between master & next as much as possible.

@changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2019

🦋 Changeset is good to go

Latest commit: 05542c0

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Andarist Andarist force-pushed the avoid-transpiling-transpiled-code branch from 8687e05 to 05542c0 Compare November 3, 2019 16:50
@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

Merging #1602 into next will decrease coverage by 0.08%.
The diff coverage is 87.5%.

Impacted Files Coverage Δ
packages/babel-plugin-emotion/src/emotion-macro.js 89.18% <87.5%> (-1.29%) ⬇️

@emmatown emmatown merged commit b0ad4f0 into next Nov 3, 2019
@emmatown emmatown deleted the avoid-transpiling-transpiled-code branch November 3, 2019 19:40
@github-actions github-actions bot mentioned this pull request Nov 8, 2019
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
@github-actions github-actions bot mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants