Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsconfig.json for emotion-theme is broken #711

Closed
Ailrun opened this issue Jun 8, 2018 · 1 comment
Closed

tsconfig.json for emotion-theme is broken #711

Ailrun opened this issue Jun 8, 2018 · 1 comment
Assignees
@Ailrun
Labels
TypeScript

Comments

@Ailrun
Copy link
Member

Ailrun commented Jun 8, 2018

  • emotion version: v9.2.2

Problem description:
tsconfig.json for emotion-theme is broken so dtslint cannot lint the typings for emotion-theme.
However, it passes Travis because of palantir/tslint#3949.

Suggested solution:
Fix tsconfig.json
@Ailrun Ailrun self-assigned this Jun 8, 2018
@Ailrun
Copy link
Member Author

Ailrun commented Jun 8, 2018 •
edited
Loading

I made a fixed version but it depends on #710.
I will send a PR after #710 is merged or rejected.

@Ailrun Ailrun mentioned this issue Jun 13, 2018
Merged
1 task
tkh44 pushed a commit that referenced this issue Jun 13, 2018
@Ailrun @tkh44
Fix tsconfig for emotion-theming (#714)
6057202 
**What**: tsconfig.json for emotion-theming package

**Why**: It does not work well with dtslint

**How**: Fix options in tsconfig.json

**Checklist**:
- [N/A] Documentation
- [N/A] Tests
- [x] Code complete

Resolves #711.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ailrun Ailrun

Labels
TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ailrun