Main rebased upon upgraded Avalon 7.2 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupplementalFile ids should always be strings New Avalon error classes Co-authored-by: Phil Dinh <phuongdh@gmail.com> Co-authored-by: Dananji Withana <dwithana@iu.edu>
Co-authored-by: phuongdh <phuongdh@gmail.com>
Co-authored-by: phuongdh <phuongdh@gmail.com>
Co-authored-by: Chris Colvard <cjcolvar@indiana.edu> Co-authored-by: Dananji Withana <dwithana@iu.edu>
Co-authored-by: cjcolvar <cjcolvar@indiana.edu>
…eyboard actions when player is on page
Remove zero-width characters from the beginning and end of all parameters in all controller actions * Add String#remove_zero_width_chars to remove all zero width unicode characters * Add before action in ApplicationController to strip zero-width characters from all parameters including child arrays and hashes. Co-authored-by: Sumith Baddam <sumith.reddy2@gmail.com>
LoadError is thrown by the AWS SDK when the activestorage adapter is set to s3 but is not configured properly.
Co-authored-by: phuongdh <phuongdh@gmail.com>
encoder class to avoid issue of #descendants iterating over all instatiated objects and possibly returning classes that are not longer declared as constants. This is probably an edge-case which only affects tests but this new approach may also be faster. Also declare classes as anonymous classes and stub constants within test.
Co-authored-by: phuongdh <phuongdh@gmail.com>
encoder class to avoid issue of #descendants iterating over all instatiated objects and possibly returning classes that are not longer declared as constants. This is probably an edge-case which only affects tests but this new approach may also be faster. Also declare classes as anonymous classes and stub constants within test.
* Refactor s3 localize code to FileLocator * Cache s3 object locally for faster waveform job * Fix passthrough test * Use Tempfile for easy clean up * Update spec/jobs/waveform_job_spec.rb Co-authored-by: Chris Colvard <cjcolvar@indiana.edu>
… for the same. (avalonmediasystem#4230) * Handling collection names with s3 special characters. Added test case for the same * Handling collection names with s3 special characters. Added test case for the same Co-authored-by: Sumith Baddam <srbaddam@iu.edu>
Co-authored-by: Phil Dinh <phuongdh@gmail.com> [WIP] Adding tests for the supplemental files controller Co-authored-by: Phil Dinh <phuongdh@gmail.com> Complete tests for supplemental files controller Co-authored-by: Phil Dinh <phuongdh@gmail.com> Move captions and supplemental to Manage Files tab Co-authored-by: Dananji Withana <dwithana@iu.edu> Fix CSS issues and rework views Co-authored-by: Dananji Withana <dwithana@iu.edu> Change forms in file upload step to update each master file in masterfiles controller Co-authored-by: Phil Dinh <phuongdh@gmail.com> Add more UI fixes for Manage files step Co-authored-by: Dananji Withana <dwithana@iu.edu> Fix CodeClimate issues Add end user UI, fix test Fix failing tests Fix indentation
Co-authored-by: Phil Dinh <phuongdh@gmail.com>
Co-authored-by: Dananji Withana <dwithana@iu.edu>
…keyboard shortcuts
* This commit also changes the uid to point to the urn for PPID and adds additional attrs to statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All files: Result of rebasing the upgraded Avalon to the 'main' branch.