Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slug field inside tab doesn't work since Nova 4.14.0 #255

Closed
FreekVR opened this issue Oct 5, 2022 · 2 comments · Fixed by #258 · May be fixed by #292
Closed

Slug field inside tab doesn't work since Nova 4.14.0 #255

FreekVR opened this issue Oct 5, 2022 · 2 comments · Fixed by #258 · May be fixed by #292

Comments

@FreekVR
Copy link

FreekVR commented Oct 5, 2022

Nova 4.14.0 included the following change:

Slug fields now return their preview from the server.

This change now yields an error given the following Tabs setup:

Tabs::make('Content', [
  Tab::make(
      'TEST',
      [
          Text::make('Foo'),
          Slug::make('Sluggy')->from('Foo')
      ]
  )
])->showTitle(),
HTTP-404 /nova-api/undefined/field/sluggy/preview

It seems where it says "undefined" in the URL, should be the resource name, but that's somehow lost when the Slug field is included in a Tab.

@ali-raza-saleem
Copy link

ali-raza-saleem commented Oct 5, 2022

Fixed Bug in New PR...
#256

@FreekVR
Copy link
Author

FreekVR commented Oct 26, 2022

I'm afraid the original issue still persists on version 2.2.3;

POST http://localhost/nova-api/undefined/field/slug:en/preview 404

Where the URL now contains "undefined" should be the resource name normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants