Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top position swipe direction #513

Merged

Conversation

hunterrmartinn
Copy link
Contributor

@hunterrmartinn hunterrmartinn commented Nov 7, 2024

🎫 Issue:

Closes #512

πŸ—’οΈ Proposed Fix:

  • Change swipeAmount to check if y is top which makes top-positioned toasts only able to be swiped upward (negative values) and bottom-positioned toasts only able to be swiped downward (positive values).

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
sonner βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 7, 2024 11:11pm

@emilkowalski emilkowalski merged commit 8a8fad1 into emilkowalski:main Nov 8, 2024
2 checks passed
@hunterrmartinn hunterrmartinn deleted the fix-top-position-swiping branch November 8, 2024 01:28
@omgcx1222
Copy link

pnpm install sonner --> "sonner": "^1.7.0"
<Toaster position="top-right" />
I still have this problem #512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: top positions have opposite swipe to dismiss directions
3 participants