Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect single-threaded mutex reentry in debug mode #433

Merged
merged 4 commits into from
May 26, 2021

Conversation

TheCallSign
Copy link
Contributor

I ran up against being unable to use egui from muliple threads in debug mode recently. I gave a shot at allowing for multithreading in debug mode by fixing this TODO:

// TODO: detect if we are trying to lock the same mutex from the same thread (bad)

This will have a penalty when running in debug mode but the trade off is that one can actually run egui in multi-threaded mode.

Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks!

@emilk emilk merged commit e320ef6 into emilk:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants