Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Let accesskit process window events #3733

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

DataTriny
Copy link
Contributor

Since accesskit_winit version 0.15.0, it is necessary to call Adapter::process_events to let AccessKit fire up window focus events on Unix and macOS. Furthermore this has always been needed on Unix (X11 only) to let AccessKit know about the window bounds, which is needed to perform hit-testing on nodes.

@DataTriny DataTriny marked this pull request as ready for review December 24, 2023 14:57
@emilk emilk added bug Something is broken eframe Relates to epi and eframe accessibility More accessible to e.g. the visually impaired egui-winit porblems related to winit labels Dec 25, 2023
@emilk
Copy link
Owner

emilk commented Dec 25, 2023

Thanks for the bug fix!

@emilk emilk changed the title egui-winit: Let AccessKit process window events Fix: Let accesskit process window events Dec 25, 2023
@emilk emilk merged commit c3a9355 into emilk:master Dec 25, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility More accessible to e.g. the visually impaired bug Something is broken eframe Relates to epi and eframe egui-winit porblems related to winit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants