fix: Cannot quit app when there is a dirty editor (eclipse-theia#13164)

Contributed by STMicroelectronics Signed-off-by: Emil HAMMARSTEDT <emil.hammarstedt@st.com>
emilhammarstedtst · Dec 13, 2023 · 3629429 · 3629429
1 parent 469bd74
commit 3629429
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/packages/core/src/browser/common-frontend-contribution.ts b/packages/core/src/browser/common-frontend-contribution.ts
@@ -1204,14 +1204,8 @@ export class CommonFrontendContribution implements FrontendApplicationContributi
                         await this.saveDirty(untitledCaptionsToSave);
                         await this.shell.saveAll();
                     });
-                    if (this.shell.canSaveAll()) {
-                        this.shouldPreventClose = true;
-                        return false;
-                    } else {
-                        this.shouldPreventClose = false;
-                        return result;
-                    }
-
+                    this.shouldPreventClose = !result;
+                    return result;
                 }
             };
         }