Linting for rviz_rendering (ros-visualization#17)

* Introduce linters in rviz_rendering

- we don't use ament_lint_common because copyright checks fail
- we want to wait for changes in ament_copyright before fixing

* Fix cppcheck errors

- only one error: memory leak of log_manager

* Extract SdkQtCameraMan from OgreBites to fix linters

- SdkQtCameraMan is from OgreBites and not from rviz
- No change in functionality

* adding a todo about the copyright linter

* add a comment about delete-less new call

rviz_rendering/CMakeLists.txt

@@ -103,4 +103,16 @@ endif()
 
 install(TARGETS rendering_example DESTINATION bin)
 
+if(BUILD_TESTING)
+    # TODO(wjwwood): replace this with ament_lint_auto() and/or add the copyright linter back
+    find_package(ament_cmake_cppcheck REQUIRED)
+    find_package(ament_cmake_cpplint REQUIRED)
+    find_package(ament_cmake_lint_cmake REQUIRED)
+    find_package(ament_cmake_uncrustify REQUIRED)
+    ament_cppcheck()
+    ament_cpplint()
+    ament_lint_cmake()
+    ament_uncrustify()
+endif()
+
 ament_package()

rviz_rendering/package.xml

@@ -22,6 +22,11 @@
   <build_depend>rviz_ogre_vendor</build_depend>
   <build_depend>qtbase5-dev</build_depend>
 
+  <test_depend>ament_cppcheck</test_depend>
+  <test_depend>ament_cpplint</test_depend>
+  <test_depend>ament_cmake</test_depend>
+  <test_depend>ament_uncrustify</test_depend>
+
   <exec_depend>assimp</exec_depend>
   <exec_depend>libogre</exec_depend>
   <exec_depend>libqt5-core</exec_depend>