Change path from sys.path[0] to . #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVHopp
commented
Jun 27, 2024
Scienfitz
requested changes
Jun 27, 2024
AdrianSosic
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Hi @AVHopp, thanks for taking care of the problem. Here two comments, though.
Scienfitz
approved these changes
Jul 1, 2024
This reverts commit d396b21.
d235d71 to
56437f4
Compare
|
@AdrianSosic I have now changed the location to |
Scienfitz
approved these changes
Jul 8, 2024
AdrianSosic
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the path for saving the results from
sys.path[0]to".".As far as I understand, this has the consequence of the images being created in the directory from which
pythonis being called, and I added a corresponding explanation at the corresponding positions.Note that this change should not have any influence on the shown images: The tests that I did on my fork showed that the static images that we insert manually into the jupyter notebooks are still correctly inserted, even with this change.