Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code #21

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Refactor code #21

merged 2 commits into from
Dec 12, 2018

Conversation

sakama
Copy link
Contributor

@sakama sakama commented Dec 12, 2018

  • Update Embulk verson v0.8.9 to v0.9.11
  • Use "java.util.Optional" instead of "com.google.common.base.Optional"

@sakama sakama requested a review from kamatama41 December 12, 2018 06:37
kamatama41
kamatama41 approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@kamatama41 kamatama41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sakama sakama merged commit bb1d689 into master Dec 12, 2018
@sakama sakama deleted the refactor-code branch December 12, 2018 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamatama41 kamatama41 kamatama41 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakama @kamatama41