Fix ember-test-selectors custom adapter for 6.x #904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 6.x release of ember-test-selectors dropped the attribute binding for classic components. This leads to a build error due to the current compat-adapter of embroider:
This PR makes the compat adapter only run for ember-test-selector versions below 6. Not sure if there is a "nicer" way to check this than to take the version of the addon pkg info, but I guess it works well enough for this case!