Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow publicAssetURL to differ from rootURL #653

Merged
merged 1 commit into from
Dec 9, 2020
Merged

allow publicAssetURL to differ from rootURL #653

merged 1 commit into from
Dec 9, 2020

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Dec 9, 2020

This serves as a replacement for the classic prepend in broccoli-asset-rev.

@ef4 ef4 force-pushed the cdn-assets branch 4 times, most recently from fc15735 to 140d4de Compare December 9, 2020 22:01
@ef4
allow publicAssetURL to differ from rootURL
b4106a7 
This serves as a replacement for the classic `prepend` in broccoli-asset-rev.
@ef4
Copy link
Contributor Author

ef4 commented Dec 9, 2020

This also slightly optimizes the HTML when not using fastboot, because before we were always emitting <fastboot-script> for lazy chunks, even when there's no fastboot in use.

@ef4 ef4 merged commit bb7c2b2 into master Dec 9, 2020
@ef4 ef4 deleted the cdn-assets branch December 9, 2020 22:49
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ef4