Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugin portability #628

Merged
merged 8 commits into from
Nov 24, 2020
Merged

Refactor plugin portability #628

merged 8 commits into from
Nov 24, 2020

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Nov 24, 2020

This cleans up and simplifies the way we pass babel and htmlbars plugins across processes.

Before we trusted to a lot of fragile code that tried to make our entire objects survive various third-party serialization & deserialization (like, inside babel-loader). Now we always emit json-clean babel config, trusting to our own launcher module to rehydrate parameters as needed.

This was also necessary to make room to implement the pluginLocationHints feature, which lets you avoid the penalty of non-serializable babel configs even if not all your upstream dependencies are playing nice, and will be in the next PR.

@ef4 ef4 merged commit aec2052 into master Nov 24, 2020
@lifeart lifeart deleted the refactor-portable branch November 24, 2020 09:34
@lifeart lifeart restored the refactor-portable branch November 24, 2020 09:35
@rwjblue rwjblue deleted the refactor-portable branch March 1, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant