Explicitly declare Node version support: 10, 12, 14+. #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates each of our published packages' `package.json` files to have the
following engines field value:
```json
{
"engines": {
"node": "10.* || 12.* || >= 14"
}
}
```
This is the list of currently supported Node releases (based on
nodejs.org).
We _may_ want to consider this a breaking change (due to the
`@embroider/router` package having had engines defined that allowed Node
8), but for most of the packages there simply was no declaration of
support at all which IMHO means adding `engines` is "safe".
rwjblue
commented
Oct 21, 2020
| "node": "8.* || >= 10.*" | ||
| "node": "10.* || 12.* || >= 14" |
There was a problem hiding this comment.
This change should probably be considered "breaking".
engines to indicate Node support.
Merged
|
(I merged master in because I want to see that my recent test suite changes are working well in a PR like this.) |
simonihmig
added a commit
that referenced
this pull request
Jun 8, 2023
This will make `macroCondition()` do full branch elimination even in development, as long as no macro is involved that has a runtime implementation (`get*Config()`, `isTesting` have). Closes #582
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates each of our published packages'
package.jsonfiles to have the following engines field value:{ "engines": { "node": "10.* || 12.* || >= 14" } }This is the list of currently supported Node releases (based on nodejs.org's release page).
We may want to consider this a breaking change (due to the
@embroider/routerpackage having had engines defined that allowed Node 8), but for most of the packages there simply was no declaration of support at all which IMHO means addingenginesis "safe".