adding support for addons that use treeFor() to suppress various trees #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general, we can't run custom `treeFor()` hooks because they expect to recurse into all their child addons and have visibility into the output of all their child addons, which we forbid. But the most common use case for `treeFor()` is quite simple, and we *can* opportunistically handle that case. It's the case where treeFor is returning either falsy or the unchanged output of `_super.treeFor()`. This letse us detect those cases and suppress trees that are supposed to get suppressed.
|
(Needs tests and needs deletion of several built-in compat adapters that should no longer be needed after this change.) |
thoov
reviewed
Oct 14, 2020
| @@ -919,3 +956,10 @@ function babelPluginAllowedInStage1(plugin: PluginItem) { | |||
| function notColocatedTemplate(path: string) { | |||
| return !/^\.\/components\/.*\.hbs$/.test(path); | |||
| } | |||
|
|
|||
| const markedEmptyTree = new UnwatchedDir(process.cwd()); | |||
| const returnMarkedEmptyTree = { | |||
There was a problem hiding this comment.
@ef4 I ran into an issue with this on an addon that calls this._super instead of this._super.treeFor. Currently the way we are mocking this as a POJO results them getting an error with: Uncaught TypeError: this._super is not a function. Obviously, this can easily be fixed by changing their call to this._super.treeFor but not sure how wide spread calling this._super is or if that is even something we should support.
There was a problem hiding this comment.
Ok, yeah, we can support that. It looks like core-object supports both, which is... ugh.
I filed #569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, we can't run custom
treeFor()hooks because they expect to recurse into all their child addons and have visibility into the output of all their child addons, which we forbid.But the most common use case for
treeFor()is quite simple, and we can opportunistically handle that case. It's the case where treeFor is returning either falsy or the unchanged output of_super.treeFor().This lets us detect those cases and suppress trees that are supposed to get suppressed.